chore(common): improve configuration detection for hextobin #12481
Conversation
This improves #12440. The previous change was a bit fragile if we updated commander versions. This change now implements a better solution that doesn't rely on dependencies and their locations for detecting if we need to run the `configure` action for hextobin.
User Test ResultsTest specification and instructions User tests are not required Test Artifacts |
The previous attempt failed when building on Windows. Using node should work everywhere.
|
Yes, this is more robust, and I see how you have set this up to work on win + mac + linux. I understand you are adding it as a postinstall script so that any Conversely, if you And this issue is more systemic than just hextobin, of course. Do you see us doing the same thing for all node projects? My main concern is that the node script is a little bit of slightly icky boilerplate to copy everywhere. If we moved the .configured file out of the build folder, and added it to the global .gitignore, then we could do it cross-platform without node: |
Addresses code review comments.
This is only necessary for node projects that either have 1) a local Hmm, maybe it's necessary for all node projects that serve as a dependency? But so far I never had problems if the dependency was in the same subtree, but that might have been luck. We'll see... |
|
Changes in this pull request will be available for download in Keyman version 18.0.122-alpha |
This improves #12440. The previous change was a bit fragile if we updated commander versions. This change now implements a better solution that doesn't rely on dependencies and their locations for detecting if we need to run the
configureaction for hextobin.@keymanapp-test-bot skip